WIP: Stage/Level and Tidal Input mode #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several users would like to be able to input river level data (Stage) and tidal levels into the model, instead of having to use discharge as an input source for reach mode style simulations.
Details
.params
file.water_depths
array.Testing
This was tested on the
Idealsied_stage.params
test case in the test folder, and also some real data using the Beverley Ship Yard gauging station (levels) on the River Hull, UK, with a DEM covering the Hull from Beverley down to hull, run over 118 days.Parameter File
Note
Note: this still features the "bug" in #53, but the workaround is simple (treat x and y as i and j matrix indices rather than coordinates - a fix for that will be made available too shortly.