Improve public uri #1491
Open
Improve public uri #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
reviewed
Jan 24, 2025
| @@ -97,7 +97,12 @@ public function resolveUri(object|array $obj, ?string $fieldName = null, ?string | |||
| $fs = $this->getFilesystem($mapping); | |||
|
|
|||
| try { | |||
| return $fs->publicUrl($path); | |||
| return $fs->publicUrl($path, [ | |||
There was a problem hiding this comment.
Could you elaborate a bit on this? I don't get why we need to pass our internal information (like the mapping and the field name) to Flysystem
There was a problem hiding this comment.
@garak sometimes, the url generator must be aware of which object and which fields is getting generated.
For example, an User entity with profilePictureFile (public) and bankDetailFile (private) fields.
The generator must generate a public url for one, and a private url with authorization for the other field.
Passing internals like mapping would not be needed in this case so it can be removed if you think it's not worth it
guillaume-sainthillier
force-pushed
the
improve-public-uri
branch
from
7665f98 to
f4bd3c4
Compare
|
You can ignore the phpstan problem, but the tests need to be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs #1486 before to be merged.
When using publicUri with flysystem, it could be necessary to have more context (the object, mapping and fieldName) to generate a public uri