Resolve line ending canonicalization issue on Windows #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronAtDuo
approved these changes
Apr 9, 2024
|
0.6.2 has been released with the fix. Thanks for the PR! And thanks for using Duo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 0.6.x versions of the client use the System.lineSeparator() method for line endings. On Windows systems, this method returns a CRLF, but Duo requires the signature input to be canonicalized with only a line feed. I reverted this behavior by directly inserting "\n" for line separators.
Motivation and Context
This allows the project to be built and run on Windows systems. Without this change, all invocations of the client from Windows returns an invalid signature error.
How Has This Been Tested?
Unit and function tested on Windows 10 and Ubuntu.
Types of Changes