Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Token Transfers #7556

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

peterrliem
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot marked this pull request as draft January 26, 2025 10:35
@github-actions github-actions bot added WIP work in progress dbt: tokens covers the Tokens dbt subproject labels Jan 26, 2025
@Hosuke
Copy link
Collaborator

Hosuke commented Jan 28, 2025

Depends on #7493

@jeff-dude
Copy link
Member

Depends on #7493

yes, due to inner join to evms.info in enrich stage, we are writing out 0 rows in CI. once dependent PR is merged, we can refresh here.

@Hosuke Hosuke removed the blocked label Jan 30, 2025
@Hosuke
Copy link
Collaborator

Hosuke commented Jan 30, 2025

Hi @peterrliem,

I have updated the PR and resolved the conflicts.
If you think this PR is ready we can mark it as Ready for review.

@jeff-dude jeff-dude marked this pull request as ready for review January 30, 2025 15:38
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 30, 2025
@Hosuke
Copy link
Collaborator

Hosuke commented Jan 30, 2025

@jeff-dude
Copy link
Member

Not sure about the CI error: https://github.com/duneanalytics/spellbook/actions/runs/13055229742/job/36426795303?pr=7556#step:12:31

this is due to trino upgrade testing on CI cluster from platform team. i will inform them. this may apply across various PRs until resolved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traces = source('abstract','traces'),
transactions = source('abstract','transactions'),
erc20_transfers = source('erc20_abstract','evt_transfer'),
native_contract_address = null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use evms.info to fill this field?

@Hosuke Hosuke added ready-for-final-review and removed ready-for-review this PR development is complete, please review labels Feb 2, 2025
@jeff-dude jeff-dude self-assigned this Feb 3, 2025
@peterrliem
Copy link
Contributor Author

peterrliem commented Feb 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: tokens covers the Tokens dbt subproject ready-for-final-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants