Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zeroex - v2 macro updates #7460

Open
wants to merge 75 commits into
base: main
Choose a base branch
from
Open

zeroex - v2 macro updates #7460

wants to merge 75 commits into from

Conversation

RantumBits
Copy link
Contributor

@RantumBits RantumBits commented Jan 13, 2025 •
edited
Loading

Description:

  • zeroex v2 macro updates

quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jan 13, 2025
@RantumBits
update source for cow trades
31ac05c
@RantumBits
remove single tx_hash case filter
24b6f78
@RantumBits
update tbl_trades cte
22ca87e
@RantumBits
add taker to settler_txs
fdc6eb7
@RantumBits
add taker to settler_txs
339bada
@RantumBits
remove gropuing from settler_txs
fad9d6c
@RantumBits
remove gropuing from settler_txs
30fc559
@RantumBits
tbl_all_logs
c959f04
@RantumBits
Remove dup contract_address column
6e3b168
@RantumBits
remove dup topic0, topic1
20e0c0b
@RantumBits
add tx_index
ab239c8
@RantumBits
zeroex_tx
bed2066
@RantumBits
add rn
827ff9b
@RantumBits
trace_address
a5e251c
@RantumBits
zeroex_v2_trades
e9c70e9
@RantumBits
zeroex_v2_trades
d5fad2a
@RantumBits
contract_address
d43ecb7
@RantumBits
contract address in cow
b4ff277
@RantumBits
contract address in cow
00d2d13
@RantumBits
contract address in cow
51f9460
@RantumBits
contract address in cow
d3fcb41
@RantumBits
-method_id
e80ebf7
@RantumBits
tx_index
0cf7f05
@RantumBits
remove poly, base models due to timeout issues
3a4276f
@RantumBits
remove changes from schema
db0829f
@RantumBits
remove base, poly from cross chain model
61c8468
@jeff-dude jeff-dude added the in review Assignee is currently reviewing the PR label Jan 21, 2025
@RantumBits
Copy link
Contributor Author

Here are value mismatch trades between new and old zeroex.trades: https://dune.com/queries/4587405

Seems new values is always larger than old values, maybe this is because of the different way of amount_usd calculation.

Also we need to determine if these trades are related with cow protocol parts.

I spot checked about 12 of these against internal maker_amounts, taker_amounts and usd_volume and found they lined up. I noticed an issue with a 0 value for taker_amounts in some cases. I'll put a fix in for those.

@RantumBits
add swap_logs cte, update taker_logs, remove cow_trades cte
8f4daf5
@RantumBits
Merge branch 'macro-2' of https://github.com/RantumBits/dune-spellbook …
06cdf21 
…into macro-2
@RantumBits
remove filter for single tx_hash
f77e39d
@RantumBits
updte to tbl_all_logs
c67676b
@RantumBits
update to tbl_all_logs
8c12a6e
@RantumBits
data
d2b7d23
@RantumBits
taker fix
725c994
@RantumBits
Merge branch 'main' into macro-2
444aa00
@RantumBits
join on rn, not index
4dbd6c7
@RantumBits
Merge branch 'macro-2' of https://github.com/RantumBits/dune-spellbook …
943f144 
…into macro-2
@RantumBits
rn
73aedad
@RantumBits
rn
5594c50
@RantumBits
add cow cte for bundled txs
ab5cdb3
@RantumBits
cow cte
36dd06e
@RantumBits
cow_rn
86657c6
@RantumBits
source in cow cte
41a6487
@RantumBits
zeroex_tx
ea32ddc
@RantumBits
add contract address
e69a7fd
@RantumBits
remove disinct to reduce stages
2b9278b
@RantumBits
remove fills_within cte
a78f6dd
@RantumBits
update valid_logs selection, maker_logs join
53a05a0
@RantumBits
add handling of batched cow trades
4f5edc3
@RantumBits
update maker_logs selection
c3fe869
@RantumBits
taker fix
09e56c0
@RantumBits
Merge branch 'main' into macro-2
0b24f08
@RantumBits
maker topics
24908d5
@RantumBits
Merge branch 'macro-2' of https://github.com/RantumBits/dune-spellbook …
7d79573 
…into macro-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hosuke Hosuke Hosuke left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Hosuke Hosuke

Labels
dbt: dex covers the DEX dbt subproject in review Assignee is currently reviewing the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RantumBits @jeff-dude @Hosuke