Pin emsdk to 3.1.71, use latest cmake for arm64 as well #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samansmink
approved these changes
Jan 16, 2025
carlopi
reviewed
Jan 16, 2025
carlopi
approved these changes
Jan 16, 2025
carlopi
changed the title
|
Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the emsdk version for wasm builds to
3.1.743.1.71 (4.0.0 was released just a couple days ago), which fixes some compilation issues in duckdb-spatial.Additionally I've managed to resolve the issues related to updating CMake in arm64 builds properly in duckdb-spatial, so this PR also reverts the changes in #129.