Skip to content

Commit

Permalink
Merge pull request #252 from duckdb/upgradefixes
Browse files Browse the repository at this point in the history
Fixes for new DuckDB version
  • Loading branch information
Mytherin authored Sep 3, 2024
2 parents d0e0115 + f292226 commit b6dda6c
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion duckdb
Submodule duckdb updated 672 files
1 change: 1 addition & 0 deletions src/postgres_query.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -92,5 +92,6 @@ PostgresQueryFunction::PostgresQueryFunction()
init_local = scan_function.init_local;
function = scan_function.function;
projection_pushdown = true;
global_initialization = TableFunctionInitialization::INITIALIZE_ON_SCHEDULE;
}
} // namespace duckdb
3 changes: 2 additions & 1 deletion src/postgres_scanner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,6 @@ double PostgresScanProgress(ClientContext &context, const FunctionData *bind_dat

lock_guard<mutex> parallel_lock(gstate.lock);
double progress = 100 * double(gstate.page_idx) / double(bind_data.pages_approx);
;
return MinValue<double>(100, progress);
}

Expand All @@ -525,6 +524,7 @@ PostgresScanFunction::PostgresScanFunction()
cardinality = PostgresScanCardinality;
table_scan_progress = PostgresScanProgress;
projection_pushdown = true;
global_initialization = TableFunctionInitialization::INITIALIZE_ON_SCHEDULE;
}

PostgresScanFunctionFilterPushdown::PostgresScanFunctionFilterPushdown()
Expand All @@ -538,6 +538,7 @@ PostgresScanFunctionFilterPushdown::PostgresScanFunctionFilterPushdown()
table_scan_progress = PostgresScanProgress;
projection_pushdown = true;
filter_pushdown = true;
global_initialization = TableFunctionInitialization::INITIALIZE_ON_SCHEDULE;
}

} // namespace duckdb
2 changes: 2 additions & 0 deletions test/sql/scanner/aws-rds.test
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# description: Read over AWS RDS
# group: [scanner]

mode skip

require postgres_scanner

require-env POSTGRES_TEST_DATABASE_AVAILABLE
Expand Down
2 changes: 2 additions & 0 deletions test/sql/storage/attach_temporary_table.test
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# description: Test attaching and querying a Postgres temporary table
# group: [storage]

mode skip

require postgres_scanner

require-env POSTGRES_TEST_DATABASE_AVAILABLE
Expand Down
2 changes: 1 addition & 1 deletion test/sql/storage/attach_types.test
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ NULL NULL NULL NULL
# test all types
statement ok
CREATE TABLE all_types_tbl AS SELECT *
EXCLUDE (float, double, ubigint, hugeint, uhugeint, nested_int_array, struct, struct_of_arrays, array_of_structs, map, "union", fixed_int_array, fixed_varchar_array, fixed_nested_int_array, fixed_nested_varchar_array, fixed_struct_array, struct_of_fixed_array, fixed_array_of_int_list, list_of_fixed_int_array)
EXCLUDE (float, double, ubigint, hugeint, uhugeint, nested_int_array, struct, struct_of_arrays, array_of_structs, map, "union", fixed_int_array, fixed_varchar_array, fixed_nested_int_array, fixed_nested_varchar_array, fixed_struct_array, struct_of_fixed_array, fixed_array_of_int_list, list_of_fixed_int_array, varint)
REPLACE(
CASE WHEN int IS NOT NULL THEN '2000-01-01' ELSE NULL END AS date,
CASE WHEN int IS NOT NULL THEN '2000-01-01 01:02:03' ELSE NULL END AS timestamp,
Expand Down

0 comments on commit b6dda6c

Please sign in to comment.