Merge pull request #257 from duckdb/issue241

Fix #241: quote FORMAT binary for old Postgres versions
duckdb · Sep 3, 2024 · 8d3ba2a · 8d3ba2a
2 parents ef26284 + 6fb9264
commit 8d3ba2a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/postgres_scanner.cpp b/src/postgres_scanner.cpp
@@ -231,14 +231,14 @@ static void PostgresInitInternal(ClientContext &context, const PostgresBindData
 		D_ASSERT(!bind_data->sql.empty());
 		lstate.sql = StringUtil::Format(
 		    R"(
-	COPY (SELECT %s FROM (%s) AS __unnamed_subquery %s) TO STDOUT (FORMAT binary);
+	COPY (SELECT %s FROM (%s) AS __unnamed_subquery %s) TO STDOUT (FORMAT "binary");
 	)",
 		    col_names, bind_data->sql, filter);
 
 	} else {
 		lstate.sql = StringUtil::Format(
 		    R"(
-	COPY (SELECT %s FROM %s.%s %s) TO STDOUT (FORMAT binary);
+	COPY (SELECT %s FROM %s.%s %s) TO STDOUT (FORMAT "binary");
 	)",
 		    col_names, KeywordHelper::WriteQuoted(bind_data->schema_name, '"'),
 		    KeywordHelper::WriteQuoted(bind_data->table_name, '"'), filter);