Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #87 - correctly quote column identifiers in INSERT INTO statement #88

Merged
merged 1 commit into from
Sep 17, 2024
+23 −2
Merged

Fix #87 - correctly quote column identifiers in INSERT INTO statement #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion duckdb
Open in desktop
Submodule duckdb updated 127 files
2 changes: 1 addition & 1 deletion src/storage/mysql_insert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ string GetBaseInsertQuery(const MySQLTableEntry &table, const vector<string> &co
if (c > 0) {
query += ", ";
}
query += column_names[c];
query += MySQLUtils::WriteIdentifier(column_names[c]);
}
query += ")";
}
Expand Down
21 changes: 21 additions & 0 deletions test/sql/attach_identifiers_insert.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# name: test/sql/attach_identifiers_insert.test
# description: Test insert by name with odd identifiers
# group: [sql]

require mysql_scanner

require-env MYSQL_TEST_DATABASE_AVAILABLE

statement ok
ATTACH 'host=localhost user=root port=0 database=mysqlscanner' AS s (TYPE MYSQL_SCANNER)

statement ok
CREATE OR REPLACE TABLE s."my table"("my column" INTEGER);

statement ok
INSERT INTO s."my table" BY NAME SELECT 42 "my column"

query I
SELECT * FROM s."my table"
----
42
Loading