chore: add CIDR functions, tests, and more documentation for a clean PR #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Jan 6, 2025
| auto address_data = FlatVector::GetData < hugeint_t > ( * entries[1]); | ||
| auto mask_data = FlatVector::GetData < uint16_t > ( * entries[2]); | ||
|
|
||
| for (idx_t i = 0; i < args.size(); i++) { |
There was a problem hiding this comment.
Can you format this using the DuckDB clang-format?
|
|
||
| # ipv6 | ||
| query I | ||
| SELECT expand_cidr(inet '2001:db8::/126'); |
There was a problem hiding this comment.
Can we add a test with NULL values?
| // Add all addresses in the range | ||
| auto current = network; | ||
| hugeint_t one(1); | ||
| for (hugeint_t j = 0; j < hosts && current.address <= broadcast.address; j = j + one) { |
There was a problem hiding this comment.
Can we add some safeguard to limit this to a certain max amount? e.g. what happens if we run expand_cidr(inet '::/0')?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
bool IsCIDR()to test whether there is a CIDR componentvoid INetFunctions::ExpandCIDR(DataChunk & args, ExpressionState & state, Vector & result)to perform the CIDR expansiontest_inet_cidr_expansion.testwith IPv4 and IPv6 testsI can make any other changes necessary