Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSE KMS on S3 #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cyberdelia
Copy link

@cyberdelia cyberdelia commented Nov 7, 2024

This adds support for Server Side Encryption via KMS on S3, by adding a new option to S3 secret named kms_key_id, and inject the proper headers to use the provided key identifier when present.

CREATE SECRET encrypted (
    TYPE S3,
    PROVIDER CREDENTIAL_CHAIN,
    CHAIN 'config',
    REGION 'eu-west-1',
    KMS_KEY_ID 'arn:aws:kms:region:acct-id:key/key-id',
    SCOPE 's3://bucket/sub/path'
);

This was tested against S3 directly, there is no tests against minio, as this seems it requires another piece of software (KES).

This is the same PR as duckdb#14475.

I made a separate commit to add a copy of duckdb's .gitignore, happy to remove if preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant