Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix physics_tend imports #486

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Fix physics_tend imports #486

merged 2 commits into from
Jan 23, 2025

Conversation

georgemccabe
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

Ran METplus use case METplus/parm/use_cases/model_applications/short_range/UserScript_fcstFV3_fcstOnly_PhysicsTendency_Planview.conf using branch of METplotpy and confirmed that the use case runs without issue.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review changes. Optionally run other 2 FV3 use cases using the change to confirm that it works as expected.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 1/27/2025.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplotpy-3.1.0 milestone Jan 23, 2025
@georgemccabe georgemccabe requested a review from bikegeek January 23, 2025 17:08
@ahijevyc
Copy link
Contributor

I tested in my environment and it works. Great catch!

@ahijevyc ahijevyc requested review from ahijevyc and removed request for ahijevyc January 23, 2025 23:42
Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also works in Dave A's environment

@bikegeek bikegeek merged commit fd08fbb into develop Jan 23, 2025
7 checks passed
@bikegeek bikegeek deleted the bugfix_physics_tend_imports branch January 23, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

3 participants