Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 394 roc #398

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Bugfix 394 roc #398

merged 4 commits into from
Nov 2, 2023

Conversation

bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Nov 1, 2023

Pull Request Testing

  • Describe testing already performed for these changes:

    from the command line, generated the ROC diagram with the following data (PCT linetype):

plot_20231024_192006.data.txt

the following yaml file:

plot_20231024_192006.yaml.txt

to generate this plot:
plot_20231024_192006

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Generate ROC diagram for the PCT linetype.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [ No]

  • Will this PR result in changes to the test suite? [ No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by Earliest convenience before beta2 release.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added this to the METplotpy-3.0.0 milestone Nov 1, 2023
@bikegeek bikegeek requested a review from TatianaBurek November 1, 2023 21:50
Copy link
Collaborator

@TatianaBurek TatianaBurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to create a few ROC plots using METviewer

@bikegeek bikegeek merged commit 098e9ba into develop Nov 2, 2023
5 checks passed
@bikegeek bikegeek deleted the bugfix_394_ROC branch November 2, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

2 participants