Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature met cyclone improvements #163

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

mollybsmith-noaa
Copy link
Collaborator

This PR improves the matching algorithm for MET Cyclone by having it match by storm_id as well as time. It also correctly filters out missing values in the MET Cyclone data, and makes error bar thickness customizable.

Copy link
Contributor

@JeffHamiltonNOAA JeffHamiltonNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Molly! Thanks for following up with Clark on this.

@JeffHamiltonNOAA JeffHamiltonNOAA merged commit fce6988 into development Nov 15, 2024
20 checks passed
@JeffHamiltonNOAA JeffHamiltonNOAA deleted the feature_met_cyclone_improvements branch November 15, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants