test: FluentAssertions removed #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasnissen
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed FluentAssertions
fluentassertions/fluentassertions#2943
Fluent assertions has changed its license model.
See video from Nick: https://www.youtube.com/watch?v=ZFc6jcaM6Ms&t=2s
Fluent assertions is just a nice to have library.
All functions can also be replaced by the classic
Xunit.Assert. This is not fluent but who cares.I would not recommend any company to use FluentAssertions and then pay 130$ per developer for it.
If you had never had a library like fluentassertions before, nobody would have thought of paying 130$ for it.
I understand it when it comes to a library where there is still a lot of development work to be done.
But the FluentAssertions Library is feature complete.
If I change the license of a library that is actually in maintanance mode, then it is a bit immoral to ask for money now if you have pushed another commercial library out of the market for years by making your library open source.
https://www.reddit.com/r/dotnet/comments/1i17jm0/fluentassertions_becomes_paid_software_for/?rdt=58726
https://opensource.guide/getting-paid/
Modern companies encourage their employees to participate in open source even during their working hours.
None of us developers can give away our working time without financial compensation.
Btw. Thank you dSPACE for allowing us to contribute to open source projects .
Even if DSCOM is only a small library, we remain OpenSource and free for use ;-)
This is just my opinion ❤️