New Gallery Component #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for hacknitr6 failed.
|
|
@HIMANSHU6001 Why is there inconsistency in your commit messages? |
ashutosh-rath02
requested changes
Jan 12, 2025
Comment on lines
+55
to
+66
| "gatsby-plugin-manifest": "^5.14.0", | ||
| "gatsby-plugin-netlify": "^5.1.1", | ||
| "gatsby-plugin-offline": "^6.14.0", | ||
| "gatsby-plugin-react-helmet": "^6.14.0", | ||
| "gatsby-plugin-robots-txt": "^1.8.0", | ||
| "gatsby-plugin-sharp": "^5.14.0", | ||
| "gatsby-plugin-sitemap": "^6.14.0", | ||
| "gatsby-plugin-styled-components": "^6.14.0", | ||
| "gatsby-transformer-sharp": "^5.14.0", | ||
| "maath": "^0.10.8", | ||
| "react": "^18.0.0", | ||
| "react-dom": "^18.0.0", |
There was a problem hiding this comment.
How are these changes related to the PR?
Comment on lines
+50
to
+63
| // Access the vertices of the geometry and modify their positions | ||
| const positionAttribute = geometry.attributes.position; | ||
|
|
||
| for (let i = 0; i < positionAttribute.count; i++) { | ||
| const x = positionAttribute.getX(i); | ||
|
|
||
| // Apply curvature only along the x-axis | ||
| const z = curvature * x * x; | ||
|
|
||
| positionAttribute.setZ(i, z); | ||
| } | ||
|
|
||
| // Update the geometry to reflect the changes | ||
| geometry.computeVertexNormals(); |
There was a problem hiding this comment.
Remove unnecessary comments.
There was a problem hiding this comment.
Move this file to config/content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Please describe your pull request.
❤️Thank you!
Post merge checklist