fix: add user prefix to entityRef in UserLink #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm.. How about if you add check for the |
drodil
reviewed
Apr 24, 2024
Revyy
changed the title
|
Great, thanks a lot, will release a fix version! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for issue: #152.
The if-statement in UserLink won't be executed at the moment if the entityRef is actually 'anonymous' as it will then always crash when executing
useEntityPresentation.A possible fix could be to move the check to the
AuthorLinkcomponent as this PR suggests.Not sure if it would need to be added in more places, like
UpdatedByLinkfor example.