Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the cache directory whenever AsyncKernel initiates its container #44

Merged
merged 3 commits into from
Feb 15, 2021

Conversation

nivpenso
Copy link
Contributor

Following this discussion.
This PR is for removing the cache dir when AsyncKernel initiates

@nivpenso
Copy link
Contributor Author

nivpenso commented Feb 10, 2021

@mmoreram don't merge it yet, i think it would make more sense to move the delete logic into the boot method rather than the initializeContainer

@nivpenso
Copy link
Contributor Author

ready to be reviewed

@mmoreram
Copy link
Member

@nivpenso amazing. Even if this is not the cleanest way of doing that (that would have been not generating it), I think that is the most efficient one.

Amazing @nivpenso, very very happy to see this PR ready to merge!

@mmoreram mmoreram merged commit aa2b3a3 into driftphp:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants