feat(frontend): complete a subscription #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
force-pushed
the
sepa-payment
branch
4 times, most recently
from
3239ba8 to
ea5e674
Compare
roschaefer
changed the title
roschaefer
force-pushed
the
sepa-payment
branch
7 times, most recently
from
1c91d2b to
7ad7e54
Compare
|
Please keep in mind that the cockpit layout will change over time (see drafts in Figma) It might be better to keep it separate from this one. |
Bettelstab
reviewed
Sep 10, 2024
| "subtitle": "Upgrade auf Premium, um weitere Funktionen freizuschalten", | ||
| "title": "Upgrade auf Premium" | ||
| }, | ||
| "sepaIban": { |
There was a problem hiding this comment.
I like how you perfectly adapt to the case conventions of this document... xD
roschaefer
force-pushed
the
sepa-payment
branch
3 times, most recently
from
fed9323 to
3e3432a
Compare
roschaefer
commented
Sep 10, 2024
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| @media #{map.get($display-breakpoints, 'md-and-up')} { | |||
| .cockpit { | |||
| grid-template-columns: 335px 335px; | |||
| grid-template-columns: 380px 380px; | |||
There was a problem hiding this comment.
I just found it extremely narrow for tablet and up.
roschaefer
commented
Sep 10, 2024
| @@ -0,0 +1,101 @@ | |||
| // source: https://github.com/derhuerst/sepa-payment-qr-code | |||
| import IBAN from 'iban' | |||
There was a problem hiding this comment.
I would like to contribute this back, as it's one of their issues: derhuerst/sepa-payment-qr-code#6
Elweyn
previously approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Seems good to show the direction.
I think that the new page payment should be in an popup, but this should be defined by @Hardy-Hart-am-Start for a next sprint
frontend/src/locales/en.json
Outdated
Comment on lines
108
to
109
| "title": "Account details", | ||
| "amount": "Amount in Euro", |
There was a problem hiding this comment.
Suggested change
| "title": "Account details", | |
| "amount": "Amount in Euro", | |
| "title": "Account details", | |
| "accountHolder": "Account owner", | |
| "amount": "Amount in Euro", |
Motivation ---------- Who: Users What: Click on a button "Complete a subscription" to send money on a monthly basis to the company running "DreamMall". Why: Because I want to support the development of this wonderful piece of software as well as the hosting and administration of it. ----------- 1. Visit http://localhost:3000/cockpit 2. Click on "Upgrade to premium" 3. See instructions how to make a bank transfer You can change the amount and it will update the QR code. There is another refactoring which affects the cockpit as a whole: I removed the `narrow` property which is unnecessary. + Increased max width and height for the cockpit cards close #1030
by @Bettelstab and @dornhoeschen
roschaefer
force-pushed
the
sepa-payment
branch
from
3e3432a to
5f9d7d3
Compare
Elweyn
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Who: Users
What: Click on a button "Complete a subscription" to send money on a monthly basis to the company running "DreamMall".
Why: Because I want to support the development of this wonderful piece of software as well as the hosting and administration of it.
You can change the amount and it will update the QR code.
There is another refactoring which affects the cockpit as a whole:
I removed the
narrowproperty which is unnecessary.close #1030