clone points to avoid race condition in ValidatePairing

drand · Apr 3, 2024 · 6d1a47b · 6d1a47b
1 parent 70a02ce
commit 6d1a47b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pairing/bn254/suite.go b/pairing/bn254/suite.go
@@ -134,8 +134,8 @@ func (s *Suite) Pair(p1 kyber.Point, p2 kyber.Point) kyber.Point {
 
 // NB: Not safe for concurrent calls
 func (s *Suite) ValidatePairing(p1, p2, inv1, inv2 kyber.Point) bool {
-	p2.(*pointG2).g.MakeAffine()
-	inv2.(*pointG2).g.MakeAffine()
+	p2.Clone().(*pointG2).g.MakeAffine()
+	inv2.Clone().(*pointG2).g.MakeAffine()
 	return s.Pair(p1, p2).Equal(s.Pair(inv1, inv2))
 }