build: Add support for linking to shared falcosecurity libraries. #2093
Conversation
Apteryks
commented
May 8, 2024
Apteryks
commented
- cmake/modules/falcosecurity-libs.cmake (USE_BUNDLED_FALCOSECURITY_LIBS): New option. Look for libsinsp via pkg-config unless it's enabled.
- userspace/sysdig/CMakeLists.txt: Adjust link directives accordingly. Remove extraneous zlib include.
|
Note that this depends on falcosecurity/libs#1842 to work. |
Apteryks
force-pushed
the
support-shared-falcosecurity-libs
branch
from
9327969 to
35ea4d3
Compare
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Not stale (that's an aggressive bot!). |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi, I'll try to update it this week. |
|
So, looking back at this, are there actual problems preventing this from being merged? I see a windows and macos-13 build failing, but maybe these are flukes/known issues? |
|
PS: that bot really gets on my nerves |
|
seems good to me! I build is currently broken and I have an ongoing PR to fix it. Once is merged I'll relaunch le build on this PR. |
|
@Apteryks do you mind rebasing before merging? |
Apteryks
force-pushed
the
support-shared-falcosecurity-libs
branch
4 times, most recently
from
0cacaea to
96ab67d
Compare
Done! |
* cmake/modules/falcosecurity-libs.cmake (USE_BUNDLED_FALCOSECURITY_LIBS): New option. Look for libsinsp via pkg-config unless it's enabled. * userspace/sysdig/CMakeLists.txt: Adjust link directives accordingly. Signed-off-by: Maxim Cournoyer <[email protected]>
* cmake/modules/falcosecurity-libs.cmake: Require falcosecurity-libs
0.20.0.
* userspace/chisel/chisel_api.cpp (lua_cbacks::get_thread_table_int):
Adjust for falcosecurity-libs commit
417e523399796d7290a479fd55988e62e80fc97e ("drop user and group infos
embedded in threadinfo."); this is a follow-up that simplifies
04f54e5 a bit.
Fixes: draios#2132
Signed-off-by: Maxim Cournoyer <[email protected]>
Apteryks
force-pushed
the
support-shared-falcosecurity-libs
branch
from
96ab67d to
4f41c30
Compare
