Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change e2e ci #416

Merged
merged 3 commits into from
Dec 6, 2024
Merged

feat: change e2e ci #416

merged 3 commits into from
Dec 6, 2024

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Dec 6, 2024

Description

refer to: oliviertassinari/react-swipeable-views#678

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: zhaoxinxin <[email protected]>
@Liam-Zhao Liam-Zhao self-assigned this Dec 6, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner December 6, 2024 03:47
Signed-off-by: zhaoxinxin <[email protected]>
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner December 6, 2024 04:09
Signed-off-by: zhaoxinxin <[email protected]>
@Liam-Zhao Liam-Zhao requested review from gaius-qi and removed request for gaius-qi December 6, 2024 04:30
@Liam-Zhao Liam-Zhao added the bug Something isn't working label Dec 6, 2024
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (686b051) to head (fed5272).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   98.23%   97.91%   -0.32%     
==========================================
  Files          36       36              
  Lines        3859     3891      +32     
  Branches     1205     1190      -15     
==========================================
+ Hits         3791     3810      +19     
- Misses         64       77      +13     
  Partials        4        4              
Files with missing lines Coverage Δ
src/components/rotation.tsx 80.00% <ø> (ø)

@gaius-qi gaius-qi merged commit af05f56 into main Dec 6, 2024
8 checks passed
@gaius-qi gaius-qi deleted the feat--change-e2e-ci branch December 6, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants