Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for SecurityBindingElement.KeyEntropyMode. #3916

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

imcarolwang
Copy link
Contributor

@StephenBonikowsky
Copy link
Member

Looks good to me, the default value is the same as on full framework.

@imcarolwang imcarolwang requested review from v-fangfc and removed request for v-fangfc September 19, 2019 01:08
@imcarolwang imcarolwang merged commit 013768e into dotnet:master Sep 19, 2019
@imcarolwang
Copy link
Contributor Author

@StephenBonikowsky this was not merged and I happen to found I am able to do the merge operation, so I merged it ...

@imcarolwang imcarolwang deleted the issue3860 branch September 19, 2019 07:51
@StephenBonikowsky
Copy link
Member

In this case that's fine, but for future PRs I want to get Matt's signoff as well. So if you have a PR that both he and I have approved and the checks are green then go ahead and merge.

You also need to do a couple other things once you merge which it looks like you did in this case...

  • move the related work item to the 'Scenario Tests' pipeline.
  • edit the description and check off the unit test field.
  • un-assign the work item

Thanks!

@imcarolwang
Copy link
Contributor Author

Ok :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants