Add transport security support for net.tcp #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for SecurityMode.Transport in net.tcp * Add in support for client X509Certificates for WCF Core * Add StreamSecurityBindingElement * Add SslStreamSecurity and supporting components * Add WindowsStreamSecurity stubs * Import IdentityModel code around X509 cert, tokens * Add support for DnsEndpointIdentity * Disable failing tests due to WindowsStreamSecurity being stubbed now (dotnet#301) * Cleanup of Tcp ClientCredentialType tests * Update project.lock.json files for new dependencies Fixes dotnet#9, dotnet#12, dotnet#81
iamjasonp
force-pushed
the
TransportSecurity-PR
branch
from
d5eaa9c to
56a4255
Compare
|
LGTM. I buddy-built and it passed all tests. I also manually copied into the TFS mirror location, built and ran all tests, which passed. I recommend merging and dealing with any comments in a follow-up PR. |
roncain
added a commit
that referenced
this pull request
Sep 2, 2015
Add transport security support for net.tcp
| base.Initialize(Claim.CreateDnsClaim(dnsName)); | ||
| } | ||
|
|
||
| public DnsEndpointIdentity(Claim identity) |
There was a problem hiding this comment.
Claim is not in public contract, do we plan to expose it? Otherwise, we should remove this public Ctor.
StephenBonikowsky
added a commit
to StephenBonikowsky/wcf
that referenced
this pull request
Sep 3, 2015
StephenBonikowsky
added a commit
to StephenBonikowsky/wcf
that referenced
this pull request
Sep 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9, #12, #81