Verify Server Dns for NetTcp binding #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hongdai
commented
Aug 3, 2015
hongdai
commented
- This is one of the key scenarios for DnsEndpointIdentity
- Note that it will fail until all dependent features mentioned in the test resolved.
| [Fact] | ||
| [ActiveIssue(12)] | ||
| [OuterLoop] | ||
| //Once this feature is enabled, we will need to add negative tests |
There was a problem hiding this comment.
NIT: consider adding this comment to the issue itself rather than putting it in code here.
There was a problem hiding this comment.
Added to the issue #12 .
|
Aside from minor nits, LGTM. |
* This is one of the key scenarios for DnsEndpointIdentity * Note that it will fail until all dependent features mentioned in the test resolved.
hongdai
added a commit
that referenced
this pull request
Aug 4, 2015
Verify Server Dns for NetTcp binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.