Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove repo level SB legs in CI and PR validation (#45765)" #46268

Closed
wants to merge 1 commit into from

Conversation

mthalman
Copy link
Member

This reverts commit cc260aa.

By not having a SB leg, it causes the sdk CI to no longer publish SB intermediates. This is a problem for repos that consume sdk's SB intermediates: dotnet/runtime#111328 (comment).

@mthalman mthalman requested a review from a team as a code owner January 24, 2025 13:49
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 24, 2025
@mmitche
Copy link
Member

mmitche commented Jan 24, 2025

Are you sure that reintroducing the repo level leg is the correct thing to do here? I think it might be to just baseline those packages in runtime.

@mthalman
Copy link
Member Author

But then there'd be no way to get updated intermediates flowed going forward.

@MichaelSimons
Copy link
Member

I thought the same thing as @mmitche. What would it look like to remove the runtime's sdk intermediate dependency and just add the prebuilts to the baseline. This is in context of the decision that we will be removing the repo SB legs in the near future. This decision should be which ever is less work. Keeping the sdk repo's SB leg working as been a non-zero cost which was the motivation for removing it.

@mmitche
Copy link
Member

mmitche commented Jan 24, 2025

But then there'd be no way to get updated intermediates flowed going forward.

Do they need them? I don't think there is useful information that comes out of having that set of intermediates flow into runtime that isn't already produced by the stage2 build of the VMR.

@mthalman
Copy link
Member Author

Closing this in favor of allowing the SDK-related prebuilts in dotnet/runtime#111328 instead of relying on the SB intermediate.

@mthalman mthalman closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants