Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][infra] Refactor running condition for runtime-ioslike and runtime-llvm pipelines #111967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matouskozak
Copy link
Member

@matouskozak matouskozak commented Jan 29, 2025

After setting up automatic runs of runtime-ioslike and runtime-llvm pipelines on PRs that touch Mono AOT-llvm code (#111614), un unwanted side effect appeared that the pipelines don't run on PRs that do not touch the selected files, even when triggered manually by comment.

To work around this, I've reverted the previous change and instead included the runtime-extra-platforms-ioslike.yml and runtime-extra-platforms-llvm.yml (previously runtime-llvm.yml) inside the runtime.yml and conditioned them by

or(
or(eq(variables['isiOSLikeOnlyBuild'], true), eq(variables['isExtraPlatformsBuild'], true)),
and(eq(variables['isRollingBuild'], false), eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_aot_llvm.containsChange'], true))

To

  1. run via runtime-ioslike or runtime-extra-platforms
  2. run automatically on PRs when Mono AOT-llvm code changes

and similarly for runtime-llvm and runtime-extra-platforms-llvm

I also removed Mono AOT-llvm jobs from runtime.yml as they are now included via runtime-extra-platforms-llvm.yml.


Before merging this PR we should:

Copy link
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

@matouskozak matouskozak requested review from jkoritzinsky, kotlarmilos, Copilot and akoeplinger and removed request for jkoritzinsky and kotlarmilos January 29, 2025 18:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • eng/pipelines/common/variables.yml: Evaluated as low risk
  • eng/pipelines/runtime-ioslike.yml: Evaluated as low risk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant