[PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance #111454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @hoyosjs |
caaavik-msft
commented
Jan 15, 2025
caaavik-msft
commented
Jan 15, 2025
3 tasks
|
If we're already making changes to this YAML, could we consider moving the YAMLs out of the coreclr folder as the perf jobs run non-coreclr perf testing as well? We'd need to have two copies of the YAML and move the pipeline definition before we could clean up, but if there's a time to do this, it's now. |
e-kharion
reviewed
Jan 16, 2025
e-kharion
reviewed
Jan 16, 2025
LoopedBard3
reviewed
Jan 17, 2025
kotlarmilos
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Copilot reviewed 12 out of 23 changed files in this pull request and generated 2 comments.
Files not reviewed (11)
- eng/pipelines/coreclr/perf-wasm-jobs.yml: Language not supported
- eng/pipelines/coreclr/perf.yml: Language not supported
- eng/pipelines/coreclr/perf_slow.yml: Language not supported
- eng/pipelines/coreclr/templates/build-and-run-perf-ios-scenarios.yml: Language not supported
- eng/pipelines/coreclr/templates/perf-job.yml: Language not supported
- eng/pipelines/coreclr/templates/perf-send-to-helix.yml: Language not supported
- eng/pipelines/coreclr/templates/run-performance-job.yml: Language not supported
- eng/pipelines/coreclr/templates/run-scenarios-job.yml: Language not supported
- eng/pipelines/common/evaluate-default-paths.yml: Evaluated as low risk
- eng/pipelines/performance/templates/perf-wasm-build-jobs.yml: Evaluated as low risk
- eng/pipelines/performance/templates/perf-arm64-build-jobs.yml: Evaluated as low risk
eng/pipelines/performance/templates/perf-ios-scenarios-build-jobs.yml
Outdated
Show resolved
Hide resolved
LoopedBard3
reviewed
Jan 30, 2025
…ents to pipelines which will be deleted in next PR.
…ces to correct values.
This was referenced Feb 1, 2025
DrewScoggins
approved these changes
Feb 3, 2025
LoopedBard3
approved these changes
Feb 3, 2025
|
The PR in the dotnet/performance repository has been merged in. I will be merging this in once I have validated that it's looking all good. I've also triggered a re-run of the pipelines from the dotnet/runtime repository against the dotnet/performance main branch so will wait for those to complete too. |
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 4, 2025
* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the dotnet/runtime portion of the work to move the performance testing YAML to the dotnet/performance repository. Please refer to the corresponding issue in the dotnet/performance repository for more information about these changes: dotnet/performance#4639