Merge pull request #74792 from dibarbet/completion_argument_trigger

Expose trigger in argument list option to vscode
dotnet · Aug 16, 2024 · 5d67a09 · 5d67a09
2 parents ee863ed + 3bc386f
commit 5d67a09
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/...er/Protocol/Handler/Configuration/DidChangeConfigurationNotificationHandler_OptionList.cs b/...er/Protocol/Handler/Configuration/DidChangeConfigurationNotificationHandler_OptionList.cs
@@ -27,6 +27,7 @@ internal partial class DidChangeConfigurationNotificationHandler
             CompletionOptionsStorage.ShowNameSuggestions,
             CompletionOptionsStorage.ProvideRegexCompletions,
             CompletionOptionsStorage.ShowItemsFromUnimportedNamespaces,
+            CompletionOptionsStorage.TriggerInArgumentLists,
             QuickInfoOptionsStorage.ShowRemarksInQuickInfo,
             MetadataAsSourceOptionsStorage.NavigateToDecompiledSources,
             HighlightingOptionsStorage.HighlightRelatedJsonComponentsUnderCursor,

diff --git a/...geServer/ProtocolUnitTests/Configuration/DidChangeConfigurationNotificationHandlerTest.cs b/...geServer/ProtocolUnitTests/Configuration/DidChangeConfigurationNotificationHandlerTest.cs
@@ -117,6 +117,7 @@ public void VerifyLspClientOptionNames()
                 "completion.dotnet_show_name_completion_suggestions",
                 "completion.dotnet_provide_regex_completions",
                 "completion.dotnet_show_completion_items_from_unimported_namespaces",
+                "completion.dotnet_trigger_completion_in_argument_lists",
                 "quick_info.dotnet_show_remarks_in_quick_info",
                 "navigation.dotnet_navigate_to_decompiled_sources",
                 "highlighting.dotnet_highlight_related_json_components",