-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the BDN version to use 0.13.1.1819. #2532
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a470e71
Update the BDN version to use 0.13.1.1819.
LoopedBard3 94ed768
Update the BDN version to use 0.13.1.1823.
LoopedBard3 2e520b8
Add category exclusion so that NoAOT can be kept for centos AOT runs.
LoopedBard3 5f7f55f
Revert "Add category exclusion so that NoAOT can be kept for centos A…
LoopedBard3 33f5452
Don't run categories that have NoAOT for the centos testing.
LoopedBard3 b17de2a
Try passing the variables all the way through.
LoopedBard3 d486667
Revert "Don't run categories that have NoAOT for the centos testing."
danmoseley 5191aea
Revert "Try passing the variables all the way through."
danmoseley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LoopedBard3 this are the only changes we need, please revert the changes to other files.
Full historical background:
OutOfMemoryException) for our CI as the build agents have simply too little memory. Make a bit of BenchmarkDotNet trimmable BenchmarkDotNet#2046 introduced a proper fix and made this particular problem go away by applying the right annotations.GC.AllocateUninitializedArrayfor the new array operator (new byte[]). This API is not supported by NativeAOT and started causing new failures that we have observed after you updated the version. This was reported in Major performance regression of the array initialization pattern roslyn#62864 and reverted in Revert "Add array initialization optimization" roslyn#62868. In theory all we need to do now is to bump BDN version and wait until Roslyn changes flow into SDK.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the other files, hope that's OK @LoopedBard3 .