Fix missing messages in streaming on CacheMissException #9309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Jan 30, 2025
| // If the token is more recent than the last purged token, then we didn't lose anything. Start from the oldest message in cache | ||
| cursor.State = CursorStates.Set; | ||
| // If the token is more recent than the last purged token, then we didn't lose anything. Start from the oldest message in cache. | ||
| // We use the state "Recovering" instead of "Set" to avoid to skip a message, since we are not pointing to the latest |
There was a problem hiding this comment.
Suggested change
| // We use the state "Recovering" instead of "Set" to avoid to skip a message, since we are not pointing to the latest | |
| // We use the state "Recovering" instead of "Set" to avoid skipping a message, since we are not pointing to the latest |
ReubenBond
reviewed
Jan 30, 2025
| @@ -265,7 +267,7 @@ private void SetCursor(Cursor cursor, StreamSequenceToken sequenceToken) | |||
| /// <returns></returns> | |||
| public bool TryGetNextMessage(object cursorObj, out IBatchContainer message) | |||
| { | |||
| message = null; | |||
| message = null; | |||
There was a problem hiding this comment.
Suggested change
| message = null; | |
| message = null; |
There was a problem hiding this comment.
seems like an errant space, or my eyes are errant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9299 and #9023
When recovering from a
CacheMissException, subscriber could miss messages if it happened during processing a handshake with the pulling agent.Microsoft Reviewers: Open in CodeFlow