[Membership] Reduce default 'stale' silo detection time from 10min to 90s #9305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix/disaster-recovery/faster-stale-detection
branch
from
37c17a5 to
528834a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default
NumMissedTableIAmAliveLimit(2) andIAmAliveTablePublishTimeout(5 min) values are very conservative. This can result in downtime of about 10 minutes after a full cluster crash + restart.This PR changes the values to 3 & 30s by default, reducing the downtime to closer to 90s after a catastrophic failure scenario.
Microsoft Reviewers: Open in CodeFlow