-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizetizer issues fixes - nuget bumps #16100
Resizetizer issues fixes - nuget bumps #16100
Conversation
Failing checks |
Hi @moljac. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time. |
Seems like nuget feed does not contain one nuget:
Seems like package is not mirrored to internal feed: https://www.nuget.org/packages/SkiaSharp.Views.WinUI/#versions-body-tab |
Seems like issues should be fixed with Svg.Skia 1.0.0.1 and this update/bump is using 1.0.0.2
|
NuGet NU1102 errors for new packages
|
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Why would the bot close this? |
Looks like it didn't remove the "needs author input" label when updates were pushed. |
Yes. I saw, but I though it is supposed to be so. I am scared of those bots. Solved conflicts and updated some packages. |
<PackageReference Include="Microsoft.Build.Framework" Version="16.7.0" PrivateAssets="all" /> | ||
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="16.7.0" PrivateAssets="all" /> | ||
<PackageReference Include="SkiaSharp" /> | ||
<PackageReference Include="SkiaSharp.Extended" /> | ||
<PackageReference Include="Microsoft.Build.Framework" Version="17.7.2" PrivateAssets="all" /> | ||
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.7.2" PrivateAssets="all" /> | ||
<PackageReference Include="SkiaSharp" Version="$(_SkiaSharpVersion)" /> | ||
<PackageReference Include="SkiaSharp.Extended" Version="2.0.0-preview.86" /> | ||
<PackageReference Include="xunit" Version="2.5.1" /> | ||
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.1" /> | ||
<PackageReference Include="coverlet.collector" Version="6.0.0" /> | ||
<PackageReference Include="Svg.Skia" /> | ||
<PackageReference Include="Svg.Skia" Version="$(SvgSkiaPackageVersion)" /> | ||
<PackageReference Update="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.4" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is oops because of
- SkiaSharp with versions
or Update
instead ofInclude
forMicrosoft.CodeAnalysis.NetAnalyzers
?
For 1)
I tried to be consistent with versions eng/Versions.props
. Is there a reason not to be?
https://github.com/dotnet/maui/blob/main/eng/Versions.props#L76-L77
<_SkiaSharpVersion>2.88.6</_SkiaSharpVersion>
<_SkiaSharpExtendedVersion>2.0.0-preview.86</_SkiaSharpExtendedVersion>
For 2)
Include
started causing nuget (error NU1504) errors recently, so I switched to Update
.
Error with Include
:
2023-09-29T07:22:21.5358710Z /Users/builder/azdo/_work/2/s/src/SingleProject/Resizetizer/test/UnitTests/Resizetizer.UnitTests.csproj : error NU1504: Warning As Error: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functionality to ensure a consistent restore behavior. The duplicate 'PackageReference' items are: Microsoft.CodeAnalysis.NetAnalyzers 7.0.4, Microsoft.CodeAnalysis.NetAnalyzers 7.0.4.
Another issue:
ExCSS used in
In In "ExCSS/4.1.4": {
"type": "package",
"compile": {
"lib/net6.0/ExCSS.dll": {}
},
"runtime": {
"lib/net6.0/ExCSS.dll": {}
}
...
"ExCSS/4.1.4": {
"sha512": "6eMFdIazPCVfr9Gios0nCUYq3/02SewnDGvS+aCi/RWaAtoETz2fNT+H//+k0vjoDJBHXkWdVG8EkxUydxtyxA==",
"type": "package",
"path": "excss/4.1.4",
"files": [
".nupkg.metadata",
".signature.p7s",
"excss.4.1.4.nupkg.sha512",
"excss.nuspec",
"lib/net452/ExCSS.dll",
"lib/net5.0/ExCSS.dll",
"lib/net6.0/ExCSS.dll",
"lib/netcoreapp3.1/ExCSS.dll",
"lib/netstandard2.0/ExCSS.dll"
]
},
and in
and
So seems like something more must be done besides updating packages in |
@mattleibow |
So now we have
which is the latest version of ExCSS https://www.nuget.org/packages/ExCSS/4.2.4 The latest version of https://www.nuget.org/packages/Svg.Custom/1.0.0.3 which depends on Thus the problem:
Let me try downgrading to
or we can try explicitly adding |
OK. Going forward: Unit tests error:
|
Assert failing
in AssertFileSize($"drawable-xhdpi/dotnet_bot.png", 498, 560); Could it be the new versions cause this assert to fail?? Changing to: AssertFileSize($"drawable-xhdpi/dotnet_bot.png", 500, 562); |
New errors (nugets)
Manual trigger for package import - done. |
@moljac I am mirroring the svg package, so maybe you can try the update again once these finish: https://dev.azure.com/dnceng/internal/_build/results?buildId=2404762&view=results. |
/azp run |
1 similar comment
/azp run |
Nuget errors (though Matthew and myself triggered package migrations several times): https://www.nuget.org/packages/Svg.Skia/1.0.0.16 https://www.nuget.org/packages/Svg.Custom/1.0.0.16 https://www.nuget.org/packages/Svg.Model/1.0.0.16 https://www.nuget.org/packages/ShimSkiaSharp/1.0.0.16
|
triggered internal mirror pipeline |
/azp run |
/rebase |
Unit tests failing:
|
Ignore number format. max error:
Errors (extracted):
|
/azp run |
0c28a1b
to
2d16298
Compare
I think the SVG library actually did do a change. They used to round down from some units (mm) and now seem to round up. I uploaded the new images for the "slightly different" images - and they look almost the same. |
commit c59c1281218105b85c83435855c241a86315fce1 Merge: 0c28a1b 49676d2 Author: Matthew Leibowitz <[email protected]> Date: Tue Apr 2 19:08:33 2024 +0200 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 0c28a1b Merge: 13ee3c8 e0b85ca Author: moljac <[email protected]> Date: Wed Mar 20 18:58:22 2024 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 13ee3c8 Author: moljac <[email protected]> Date: Fri Mar 15 17:59:23 2024 +0100 fixes for obsolete classes commit 9dd7bfe Author: moljac <[email protected]> Date: Fri Mar 15 09:52:51 2024 +0100 Svg.Skia bumped to 1.0.0.16 that has netstandard2.0 package commit e45d3cf Author: moljac <[email protected]> Date: Thu Mar 14 20:18:55 2024 +0100 downgrade Svg.Skia commit f1c8b3d Author: moljac <[email protected]> Date: Wed Mar 13 18:56:06 2024 +0100 Update Versions.props commit e663e62 Merge: 4cfef26 289b6c2 Author: moljac <[email protected]> Date: Wed Mar 13 15:40:49 2024 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 4cfef26 Author: moljac <[email protected]> Date: Wed Mar 6 15:23:49 2024 +0100 downgrade because of removed netstandard2.0 TFM commit 7b9d04c Author: moljac <[email protected]> Date: Mon Mar 4 21:33:33 2024 +0100 bumped SvgSkia and ExCSS again commit 3c9ff0a Merge: 0b688bb 126f47a Author: moljac <[email protected]> Date: Mon Mar 4 20:26:58 2024 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 0b688bb Merge: 35febc9 6ec214f Author: moljac <[email protected]> Date: Tue Nov 14 10:49:50 2023 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 35febc9 Merge: b5666d6 b414925 Author: moljac <[email protected]> Date: Wed Nov 8 22:33:58 2023 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit b5666d6 Author: moljac <[email protected]> Date: Wed Nov 8 16:33:04 2023 +0100 reverted case sensitive filename fix commit 6de2948 Merge: b321b9a b170fbb Author: moljac <[email protected]> Date: Wed Nov 8 15:35:25 2023 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit b321b9a Author: moljac <[email protected]> Date: Wed Nov 8 15:07:31 2023 +0100 workarounds for unit tests (off by 1 pixel errors) commit acaed1d Author: moljac <[email protected]> Date: Tue Nov 7 17:04:42 2023 +0100 another pixel assert fixed commit 4978ea3 Author: moljac <[email protected]> Date: Tue Nov 7 17:01:56 2023 +0100 skColor for pixel assert added commit e9966c6 Author: moljac <[email protected]> Date: Tue Nov 7 16:57:58 2023 +0100 reverting assert commit 92a50e6 Author: moljac <[email protected]> Date: Tue Nov 7 09:36:16 2023 +0100 more assert workarounds commit 3084e77 Author: moljac <[email protected]> Date: Tue Nov 7 08:06:09 2023 +0100 another assert fixed commit 50d2c98 Merge: 4dea747 c02a670 Author: moljac <[email protected]> Date: Tue Nov 7 08:05:49 2023 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 4dea747 Merge: f53c953 7b06dba Author: moljac <[email protected]> Date: Mon Nov 6 21:39:05 2023 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit f53c953 Author: moljac <[email protected]> Date: Mon Nov 6 21:36:01 2023 +0100 assert fix commit 90ce477 Merge: d5a152d 7be95d4 Author: moljac <[email protected]> Date: Mon Nov 6 20:26:11 2023 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit d5a152d Author: moljac <[email protected]> Date: Mon Nov 6 20:25:34 2023 +0100 fix casesensitivity commit 16187d3 Author: moljac <[email protected]> Date: Sun Nov 5 09:40:45 2023 +0100 downgrade ExCSSPackageVersion commit f2ae325 Merge: 6413516 a5f717b Author: moljac <[email protected]> Date: Sat Nov 4 14:25:26 2023 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 6413516 Author: moljac <[email protected]> Date: Tue Oct 31 16:49:07 2023 +0100 Update Resizetizer.UnitTests.csproj commit e59d443 Author: moljac <[email protected]> Date: Tue Oct 31 16:48:32 2023 +0100 bumped versions for assembly references which were causing CI failures commit 3b328ec Merge: 065f9bf a589b12 Author: moljac <[email protected]> Date: Tue Oct 31 11:10:12 2023 +0100 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 065f9bf Author: moljac <[email protected]> Date: Fri Sep 29 09:12:27 2023 +0200 propert used instead of literal (_SkiaSharpExtendedVersion) commit 289eaed Author: moljac <[email protected]> Date: Fri Sep 29 09:05:15 2023 +0200 reverted to Include instead of Update commit a4c6c78 Author: moljac <[email protected]> Date: Thu Sep 28 17:51:07 2023 +0200 duplicare PackageReference fix commit d0fcdd7 Merge: da2c6e8 9895399 Author: moljac <[email protected]> Date: Wed Sep 27 10:54:24 2023 +0200 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit da2c6e8 Author: moljac <[email protected]> Date: Wed Sep 20 13:05:04 2023 +0200 bumped to newest versions commit 433c12f Author: moljac <[email protected]> Date: Tue Sep 5 21:59:55 2023 +0200 test for issue 15442 commit 4a4f793 Merge: 91292c6 c05b2a0 Author: moljac <[email protected]> Date: Tue Sep 5 12:43:02 2023 +0200 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 91292c6 Author: moljac <[email protected]> Date: Tue Sep 5 12:40:04 2023 +0200 size fix (error on CI test runs) commit fff5b1b Author: moljac <[email protected]> Date: Tue Sep 5 12:39:45 2023 +0200 nuget bumps commit 1965362 Merge: 97f49de 51c7287 Author: moljac <[email protected]> Date: Tue Aug 8 16:42:06 2023 +0200 Merge branch 'main' into dev--moljac--fix-resizetizer-invalid-png-from-svg commit 97f49de Author: moljac <[email protected]> Date: Thu Jul 13 10:01:27 2023 +0200 updated unit test to reflect png image with issue commit 6c3a7aa Author: Matthew Leibowitz <[email protected]> Date: Wed Jul 12 20:09:58 2023 +0200 I think this is the correct way commit 6490514 Author: moljac <[email protected]> Date: Wed Jul 12 12:05:45 2023 +0200 Added test for SVG image with issue commit dee1995 Author: moljac <[email protected]> Date: Wed Jul 12 10:58:10 2023 +0200 Resizetizer unit tests nugets updates commit de0d510 Author: moljac <[email protected]> Date: Wed Jul 12 10:57:45 2023 +0200 Resizetizer nuget updates commit 8dd6fc8 Author: moljac <[email protected]> Date: Tue Jul 11 20:57:38 2023 +0200 test added commit 6529151 Author: moljac <[email protected]> Date: Tue Jul 11 20:57:29 2023 +0200 Skia.Svg version bumped/updated commit 1faa261 Author: moljac <[email protected]> Date: Tue Jul 11 20:57:14 2023 +0200 Skia.Svg version bumped/updated commit 0abf144 Author: moljac <[email protected]> Date: Tue Jul 11 20:56:56 2023 +0200 new problematic icon added
2d16298
to
ddc3bd5
Compare
Description of Change
Bumped version od SkiaSharp from 0.5.13 to 1.0.0.
Context:
There are several issues that report issues with conversion from SVG to PNG by Resizetizer which uses Svg.Skia package.
If update does not work, then we should advise users to open issue in Svg.Skia repo with svg files that cause issues.
https://github.com/wieslawsoltes/Svg.Skia
Other possibility would be to use other managed library:
svg-net
https://github.com/svg-net/SVG
http://svg-net.github.io/SVG/
INVESTIGATED: