This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Fix NYI's for Function Pointers #8200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suchiman
force-pushed
the
FixFunctionPointers
branch
from
faf2d43 to
63a3399
Compare
| case Internal.TypeSystem.TypeFlags.FunctionPointer: | ||
| throw new NotImplementedException("FunctionPointer signature"); | ||
| return new NativeLayoutEETypeSignatureVertexNode(factory, factory.TypeSystemContext.GetWellKnownType(WellKnownType.IntPtr)); |
There was a problem hiding this comment.
These are interned, so it would be better to add handling for this case in NodeFactory.NativeLayout.cs (where NewTypeSignatureVertexNode is called).
| return true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Nit: instead of the if (IsReflectionBlocked(signature.ReturnType)) block above, this could just be return IsReflectionBlocked(signature.ReturnType), saving 5 lines of code.
Suchiman
force-pushed
the
FixFunctionPointers
branch
from
63a3399 to
4a5f22e
Compare
MichalStrehovsky
approved these changes
Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IsReflectionBlockedfix is rather theoretical as i didn't manage to hit it locally.Fixes #8199