Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for methods with multiple JSInvokable attributes #59787

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improve support for methods with multiple JSInvokable attributes #59787

wants to merge 4 commits into from

Conversation

rsandbach
Copy link

Improve support for methods with multiple JSInvokable attributes

Change ScanAssemblyForCallableMethods and ScanTypeForCallableMethods to call GetCustomAttribute_s_ instead of GetCustomAttribute. Add all the defined identifiers as opposed to crashing on an unhandled AmbiguousMatchException.

Description

Fixes #54646

@rsandbach rsandbach requested a review from a team as a code owner January 9, 2025 05:12
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Jan 9, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @rsandbach. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 9, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 16, 2025
@javiercn
Copy link
Member

/azp run aspnetcore-ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@javiercn javiercn removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSInvokableAttribute - No details on where the issue is. Undebuggable.
2 participants
@rsandbach @javiercn