Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance location of <script> tags coverage #34528

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Enhance location of <script> tags coverage #34528

merged 1 commit into from
Jan 21, 2025

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jan 21, 2025

Fixes #34371

@hakenr ... This generalizes the reason ('the tag can't be updated dynamically') to just a recommendation not to place the tag and specifies the condition (static SSR w/o enhanced nav). I feel good about this update. How do you feel about it?


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/javascript-interoperability/location-of-javascript.md aspnetcore/blazor/javascript-interoperability/location-of-javascript

@guardrex guardrex self-assigned this Jan 21, 2025
@guardrex guardrex mentioned this pull request Jan 21, 2025
68 tasks
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guardrex guardrex merged commit a52acaf into main Jan 21, 2025
3 checks passed
@guardrex guardrex deleted the guardrex-patch-4 branch January 21, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assess guidance on use of <script> tags in components
2 participants