WIP: Docker container #22
Conversation
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Dev Release | ||
| if: startsWith(github.ref, 'refs/heads/') # Just the branches |
There was a problem hiding this comment.
GitHub also provides github.ref_type, which is either tag or branch, so I'd recommend the following:
if: github.ref_type == 'branch'
| - name: Set environment | ||
| run: | | ||
| VERSION="$(cat .VERSION)" | ||
| MAJORVERSION="$(cat .VERSION | cut -c 1-2 | sed -r 's#^(.{0})#\1latest-#')" |
There was a problem hiding this comment.
MAJORVERSION is not used as far as I can tell, could we remove this line?
| export TAG="${GITHUB_REF#'refs/tags/'}" | ||
| echo "GH_TAG=$TAG" >> $GITHUB_ENV |
There was a problem hiding this comment.
Prefer using GITHUB_REF_NAME here, which will resolve to either master on the master branch, or to the tag name when pushing a tag.
| org.opencontainers.image.documentation="https://github.com/buanet/ioBroker.docker#readme" \ | ||
| org.opencontainers.image.authors="Marcel A." \ |
There was a problem hiding this comment.
We should update these lines to fit Dungeon Club (you're welcome to include your name in the authors field of the Dockerfile)
| if [[ -f /opt/.docker_config/.first_run ]]; then | ||
| echo "----- Download and Unzip Ambience Music -----" | ||
|
|
||
| wget --no-check-certificate -O ../app/ambience/music-bundle.zip "https://evi.nl.tab.digital/s/y2w7b7e7ztPRYra/download" \ |
There was a problem hiding this comment.
I've created a Nextcloud account with the music bundle available to download, we can now use the following link: https://evi.nl.tab.digital/s/cKjTZ7reBkGJgHG
| environment: | ||
| - ENABLE_MUSIC_PLAYER=false | ||
| volumes: | ||
| - ./DungeonClub_Data:/app |
There was a problem hiding this comment.
Regarding the folder name, I'd suggest docker/dungeonclub_data in all lowercase.
| ```yml | ||
| version 2.1 | ||
|
|
||
| services: | ||
| dungeonclub: | ||
| image: ghcr.io/doodlezucc/dungeonclub:latest | ||
| container_name: dungeonclub | ||
| ports: | ||
| - 7070:7070 | ||
| restart: always | ||
| environment: | ||
| - ENABLE_MUSIC_PLAYER=false | ||
| volumes: | ||
| - <path-to-data>:/app | ||
| ``` |
There was a problem hiding this comment.
Should we link to the docker-compose.yml file instead? That way there would be a single point to view and edit the compose file.
| version: "2.1" | ||
| services: | ||
| dungeonclub: | ||
| image: dungeonclub:latest |
There was a problem hiding this comment.
I don't know Docker that well, so forgive me if this is a silly question. By putting dungeonclub:latest here, would the compose file search Docker Hub for a repository named dungeonclub with the tag latest? I saw you using ghcr.io/doodlezucc/dungeonclub:latest as an image in the readme file, which I guess would point to the GitHub package.
| # Prepare .docker_config | ||
| && mkdir /opt/.docker_config \ | ||
| && echo "${VERSION}" > /opt/.docker_config/.thisisdocker \ | ||
| && echo "true" > /opt/.docker_config/.first_run |
There was a problem hiding this comment.
I can't seem to find a point where the .first_run file gets deleted as of now, or maybe I missed it. Does first_run get set to false?
|
|
||
| # TODO: refactor this to not repeat all the code in the Dev Release step | ||
| - name: Version Release | ||
| if: startsWith(github.ref, 'refs/tags/') # Just the tags |
There was a problem hiding this comment.
The opposite of the upper condition would be:
if: github.ref_type == 'tag'
No description provided.