Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update 2nd and add 3rd ts solution to lc problem: No.1438 #3160

Merged
merged 15 commits into from
Jun 25, 2024

Conversation

rain84
Copy link
Contributor

@rain84 rain84 commented Jun 24, 2024

No description provided.

@idoocs idoocs added md Issues or Pull requests relate to .md files ts Issues or Pull requests relate to .ts code labels Jun 24, 2024
@idoocs
Copy link
Member

idoocs commented Jun 24, 2024

🤭 感谢你的提交,请检查你的改动是否符合以下项目规范。

1. 格式化

我们项目中各种编程语言代码(包括文档)所采用的格式化工具不同,提交 pr 之前必须确保代码、文档正确格式化。

  • .{md,js,ts,php,sql,rs} 采用 prettier
  • .{c,cpp,java} 采用 clang-format
  • .{py} 采用 black
  • .{go} 采用 gofmt
  • 其它待完善

2. Git 提交信息

我们项目遵循 AngularJS Git Commit Message Conventions 规范,我们希望你的提交信息尽可能与项目保持一致。

  • 新增或修改题解:feat: add/update solution(s) to lc problem(s): No.xxxx
  • 修复错误:fix: xxxx
  • 日常维护:chore: xxx

3. 其它补充

新增题解及代码时,需要创建 Solution.xxx 源代码文件(如果已存在,请确认算法是否更优,是则覆盖已有算法代码),同时,需要在 README.md 以及 README_EN.md 中添加对应的代码片段(英文文件中不要出现中文注释)
另外,编码风格(比如变量、函数的命名),尽量跟项目已有代码保持一致。


🤭 Thank you for your contribution. Please check if your changes comply with the following project specifications.

1. Formatting

We use different formatting tools for various programming languages (including documentation) in our project. You must ensure that the code and documentation are correctly formatted before submitting a pr.

  • .{md,js,ts,php,sql,rs} use prettier
  • .{c,cpp,java} use clang-format
  • .{py} use black
  • .{go} use gofmt
  • Others to be improved

2. Git Commit Message

Our project follows the AngularJS Git Commit Message Conventions. We hope that your submission information is as consistent as possible with the project.

  • Add or modify solutions: feat: add/update solution(s) to lc problem(s): No.xxxx
  • Fix errors: fix: xxxx
  • Routine maintenance: chore: xxx

3. Other notes

When adding solutions and code, you need to create a Solution.xxx source code file (if it already exists, please confirm whether the algorithm is better, if yes, overwrite the existing algorithm code), and at the same time, you need to add the corresponding code snippets in README.md and README_EN.md (do not have Chinese comments in the English file)
In addition, the coding style (such as the naming of variables and functions) should be as consistent as possible with the existing code in the project.

@rain84 rain84 force-pushed the feature/lc-1438 branch from ed08208 to 9111c59 Compare June 24, 2024 13:20
@rain84 rain84 changed the title feat: add 3rd ts solution to lc problem: No.1438 feat: update 2nd and add 3rd ts solution to lc problem: No.1438 Jun 24, 2024
@yanglbme
Copy link
Member

Hello, if you use a max-heap and a min-heap, you can utilize MaxPriorityQueue and MinPriorityQueue.

Reference: https://doocs.github.io/leetcode/en/lc/2163/

@idoocs idoocs added the py Issues or Pull requests relate to .py code label Jun 25, 2024
@idoocs idoocs added java Issues or Pull requests relate to .java code cpp Issues or Pull requests relate to .cpp code labels Jun 25, 2024
@idoocs idoocs added the go Issues or Pull requests relate to .go code label Jun 25, 2024
yanglbme
yanglbme previously approved these changes Jun 25, 2024
yanglbme
yanglbme previously approved these changes Jun 25, 2024
@rain84
Copy link
Contributor Author

rain84 commented Jun 25, 2024

Hello, if you use a max-heap and a min-heap, you can utilize MaxPriorityQueue and MinPriorityQueue.

Reference: https://doocs.github.io/leetcode/en/lc/2163/
Hi, @yanglbme

Where I can find realisation of Min/Max PriorityQueue?
As I see it comes from a global environment.
I have my own realisation, but it has some subtle bug in "sinkingDown"-method.

@yanglbme
Copy link
Member

@rain84 https://github.com/datastructures-js/priority-queue/blob/v5/README.md

This library has already been integrated into the LeetCode platform, and you can use it directly.

@yanglbme yanglbme merged commit 5be8a6f into doocs:main Jun 25, 2024
4 checks passed
@rain84 rain84 deleted the feature/lc-1438 branch June 25, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Issues or Pull requests relate to .cpp code go Issues or Pull requests relate to .go code java Issues or Pull requests relate to .java code md Issues or Pull requests relate to .md files py Issues or Pull requests relate to .py code ts Issues or Pull requests relate to .ts code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants