GraphNode: Improve performance of node disposal in large ref lists #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 80.26% 80.30% +0.03%
==========================================
Files 5 5
Lines 598 599 +1
Branches 34 32 -2
==========================================
+ Hits 480 481 +1
Misses 117 117
Partials 1 1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More optimization could be done here, but I'm concerned that complex behavior changes (batch disposal, lazy cleanup, etc.) could have more side effects and maintenance requirements than I'm prepared to deal with.
In glTF Transform v4, I'm tempted to use Sets for RefLists, which should help here dramatically, but that is a breaking change to APIs, and doesn't justify a major release right now.
This change is simple enough, and improves performance dramatically when disposing of items in large reference lists. On quick benchmarks, this was a 5x performance improvement for a list containing 30,000 items.
Related: