Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default session timeout 3s. #672

Closed
wants to merge 3 commits into from
Closed

Conversation

ye4241
Copy link

@ye4241 ye4241 commented Mar 2, 2024

Summary

Try to fix issue: #671, now bot starts faster.

General Info

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue (please put issue # in summary).
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@dolfies dolfies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just run black to get the CI passing.

@ye4241
Copy link
Author

ye4241 commented Mar 22, 2024

@dolfies I have format file with black==22.6, please check it again.

@dolfies
Copy link
Owner

dolfies commented May 15, 2024

Thanks for the PR! Unfortunately, there's an issue with aiohttp's default timeout implementation that causes conflicts with the library's cleanup process. I'll implement this myself in the TLS refactor.

@dolfies dolfies closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants