Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow people to send metadata with activity and fix a bug #649

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

MrStretchd
Copy link

Summary

It fixes the issue of people not being able to see their rpc, if they haven't set their buttons in the Activity() class. Discord doesn't seem to show the presence if a empty list of buttons is sent, so I made the default a None instead of a list.

I also gave the Activity() class access to metadata, so people could configure button urls. The implementation is basic and ignoring the Metadata() class. It could be improved.

General Info

  • [x ] If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue (please put issue # in summary).
  • [x ] This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@dolfies dolfies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this as a temporary fix for now, but activities need a large rework in general :)

@dolfies dolfies merged commit 763eb2e into dolfies:master Jan 13, 2024
2 of 3 checks passed
lolinekord added a commit to lolinekord/discord.py-self that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants