Fix all new lint errors

dolanmiu · Oct 21, 2024 · 29a6eb7 · 29a6eb7
1 parent 18e175e
commit 29a6eb7
Show file tree

Hide file tree

Showing 214 changed files with 648 additions and 435 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -5,5 +5,6 @@
     "editor.formatOnSave": false,
     "prettier.tabWidth": 4,
     "prettier.arrowParens": "always",
-    "prettier.bracketSpacing": true
+    "prettier.bracketSpacing": true,
+    "eslint.useFlatConfig": true
 }
diff --git a/eslint.config.ts b/eslint.config.ts
@@ -1,28 +1,24 @@
 import eslint from "@eslint/js";
 import type { Linter } from "eslint";
-import _import from "eslint-plugin-import";
-import noNull from "eslint-plugin-no-null";
+import importPlugin from "eslint-plugin-import";
 import unicorn from "eslint-plugin-unicorn";
 import jsdoc from "eslint-plugin-jsdoc";
 import preferArrow from "eslint-plugin-prefer-arrow";
 import functional from "eslint-plugin-functional";
-import { fixupPluginRules } from "@eslint/compat";
 import globals from "globals";
-import tsEslint from 'typescript-eslint';
-
+import tsEslint from "typescript-eslint";
 
 const config: Linter.Config<Linter.RulesRecord>[] = [
     {
         ignores: ["**/vite.config.ts", "**/build/**", "**/coverage/**", "**/*.js", "eslint.config.ts", "**/demo/**", "**/scripts/**"],
     },
     eslint.configs.recommended,
+    importPlugin.flatConfigs.recommended,
     ...tsEslint.configs.recommended,
     ...tsEslint.configs.stylistic,
     {
         files: ["**/src/**/*.ts"],
         plugins: {
-            import: fixupPluginRules(_import),
-            "no-null": noNull,
             unicorn,
             jsdoc,
             "prefer-arrow": preferArrow,
@@ -36,6 +32,13 @@ const config: Linter.Config<Linter.RulesRecord>[] = [
             },
         },
 
+        settings: {
+            "import/resolver": {
+                typescript: true,
+                node: true,
+            },
+        },
+
         rules: {
             "no-undef": "off",
             "no-extra-boolean-cast": "off",
@@ -217,7 +220,30 @@ const config: Linter.Config<Linter.RulesRecord>[] = [
             "import/no-default-export": "error",
             "import/no-extraneous-dependencies": "off",
             "import/no-internal-modules": "off",
-            "import/order": "error",
+            "sort-imports": [
+                "error",
+                {
+                    allowSeparatedGroups: true,
+                    ignoreDeclarationSort: true,
+                },
+            ],
+            "import/order": [
+                "error",
+                {
+                    groups: [["external", "builtin"], "internal", ["sibling", "parent", "index"]],
+                    "newlines-between": "always",
+                    pathGroups: [
+                        { pattern: "@file/**/*", group: "internal" },
+                        { pattern: "@file/**", group: "internal" },
+                        { pattern: "@export/**", group: "internal" },
+                    ],
+                    pathGroupsExcludedImportTypes: ["internal"],
+                    alphabetize: {
+                        order: "asc",
+                        caseInsensitive: true,
+                    },
+                },
+            ],
             indent: "off",
             "jsdoc/check-alignment": "error",
             "jsdoc/check-indentation": "off",
@@ -240,7 +266,6 @@ const config: Linter.Config<Linter.RulesRecord>[] = [
             "no-multiple-empty-lines": "error",
             "no-new-func": "error",
             "no-new-wrappers": "error",
-            "no-null/no-null": "error",
             "no-param-reassign": "error",
             "no-redeclare": "error",
             "no-return-await": "error",
@@ -308,8 +333,6 @@ const config: Linter.Config<Linter.RulesRecord>[] = [
     {
         files: ["**/*.spec.ts"],
         plugins: {
-            import: fixupPluginRules(_import),
-            "no-null": noNull,
             unicorn,
             jsdoc,
             "prefer-arrow": preferArrow,

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -22,7 +22,7 @@
         "test": "vitest --ui --coverage",
         "test:ci": "vitest run --coverage",
         "prepublishOnly": "npm run build --omit=dev",
-        "lint": "npx eslint --flag unstable_ts_config --config eslint.config.ts",
+        "lint": "eslint --flag unstable_ts_config --config eslint.config.ts",
         "predemo": "npm run build",
         "demo": "tsx ./demo/index.ts",
         "typedoc": "typedoc src/index.ts --tsconfig tsconfig.typedoc.json",
@@ -81,6 +81,7 @@
         "cspell": "^8.2.3",
         "docsify-cli": "^4.3.0",
         "eslint": "^9.13.0",
+        "eslint-import-resolver-typescript": "^3.6.3",
         "eslint-plugin-functional": "^7.0.2",
         "eslint-plugin-import": "^2.26.0",
         "eslint-plugin-jsdoc": "^50.3.1",

diff --git a/src/export/formatter.ts b/src/export/formatter.ts
@@ -1,7 +1,6 @@
 import { BaseXmlComponent, IContext, IXmlableObject } from "@file/xml-components";
 
 export class Formatter {
-    // tslint:disable-next-line: no-object-literal-type-assertion
     public format(input: BaseXmlComponent, context: IContext = { stack: [] } as unknown as IContext): IXmlableObject {
         const output = input.prepForXml(context);