Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CMake version 3.5 or newer. #13

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Require CMake version 3.5 or newer. #13

merged 2 commits into from
Nov 22, 2023

Conversation

gruenich
Copy link
Contributor

Recent releases of CMake warn that older versions than 3.5 might become unsupported.

@gruenich
Copy link
Contributor Author

@dokempf Do you mind reviewing this pull request and consider merging it?

Copy link
Owner

@dokempf dokempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks!

@gruenich
Copy link
Contributor Author

I added another commit to fix another minor warning

Recent releases of CMake warn that older versions than
3.5 might become unsupported.
More recent versions of CMake emit a warning otherwise
@gruenich
Copy link
Contributor Author

Now the checks have passed. 😄

@dokempf dokempf merged commit 7922306 into dokempf:main Nov 22, 2023
1 check passed
@gruenich gruenich deleted the feature/require-cmake-3.5 branch November 22, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants