chore(devcontainer): update image: v1.1.0 #2960
Conversation
WalkthroughOhayo, sensei! This pull request focuses on updating the Docker image version across multiple configuration files from a specific commit hash Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/bench.yml (1)
17-17: Consider documenting version update impact.Since this is a version update that affects both benchmark jobs, it would be helpful to document any significant changes or improvements in the new image version that might impact the benchmark results.
Also applies to: 39-39
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.devcontainer/devcontainer.json(1 hunks).github/workflows/bench.yml(2 hunks).github/workflows/ci.yml(6 hunks).github/workflows/release-dispatch.yml(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- .github/workflows/ci.yml
- .github/workflows/release-dispatch.yml
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: clippy
🔇 Additional comments (2)
.github/workflows/bench.yml (2)
17-17: LGTM! Version update for bench-katana job.The Docker image version is consistent with the devcontainer configuration.
39-39: LGTM! Version update for bench-sozo job.The Docker image version is consistent with the devcontainer configuration.
| @@ -2,7 +2,7 @@ | |||
| // https://github.com/microsoft/vscode-dev-containers/tree/v0.245.2/containers/rust | |||
| { | |||
| "name": "Rust", | |||
| "image": "ghcr.io/dojoengine/dojo-dev:b37b325", | |||
| "image": "ghcr.io/dojoengine/dojo-dev:v1.1.0", | |||
There was a problem hiding this comment.
💡 Codebase verification
Ohayo sensei! The Docker image version v1.1.0 does not exist! 🚨
The specified version v1.1.0 is not available in the container registry. The latest semantic version available is v0.1.0. Please either:
- Use an existing version (e.g.,
v0.1.0orlatest) - Consult with the Dojo team about the correct version to use
🔗 Analysis chain
Ohayo sensei! Let's verify the Docker image version.
The change from commit hash b37b325 to semantic version v1.1.0 is a good practice for better version tracking.
Let's confirm that this version exists and is stable:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the Docker image version exists and check its details
# Check if the image exists and get its details
curl -s -H "Authorization: Bearer $(curl -s "https://ghcr.io/token?scope=repository:dojoengine/dojo-dev:pull" | jq -r .token)" \
https://ghcr.io/v2/dojoengine/dojo-dev/manifests/v1.1.0 | jq .
# Get the image creation date and other metadata
curl -s -H "Authorization: Bearer $(curl -s "https://ghcr.io/token?scope=repository:dojoengine/dojo-dev:pull" | jq -r .token)" \
https://ghcr.io/v2/dojoengine/dojo-dev/tags/list | jq '.tags[]'
Length of output: 4030
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2960 +/- ##
=======================================
Coverage 56.71% 56.72%
=======================================
Files 420 420
Lines 55557 55557
=======================================
+ Hits 31507 31512 +5
+ Misses 24050 24045 -5 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
b37b325to version tagv1.1.0