fix(katana-cli): use messaging in config file

[broody]

Summary by CodeRabbit

• New Features
  • Enhanced configuration flexibility by allowing messaging settings to be loaded from configuration files when not explicitly set via command line arguments.

[coderabbitai]

Ohayo, sensei! Let's break down these changes with precision and clarity.

Walkthrough

The pull request introduces a modification to the configuration handling in the Katana CLI. Specifically, the change enhances the with_config_file method in the NodeArgs struct to provide more flexible configuration merging. The key addition is a conditional check that populates the messaging field from the configuration file when it hasn't been explicitly set via command-line arguments.

Changes

File	Change Summary
crates/katana/cli/src/args.rs	- Added conditional logic to assign messaging from config file if not set - Introduced pub messaging: Option<MessagingConfig> field in NodeArgs struct

Sequence Diagram

sequenceDiagram
    participant CLI as Command Line Interface
    participant Config as Configuration File
    participant NodeArgs as NodeArgs Struct

    CLI ->> NodeArgs: Initialize with arguments
    Config ->> NodeArgs: Merge configuration
    alt Messaging not set by CLI
        Config -->> NodeArgs: Assign messaging config
    end

Loading

The sequence diagram illustrates how the configuration merging now works, with a specific focus on the new messaging configuration handling. When the CLI arguments don't explicitly set the messaging configuration, the method now seamlessly pulls it from the configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/katana/cli/src/args.rs (1)

373-376: Consider removing the extra newline for consistency, sensei!

The implementation is correct, but there's an extra newline after the messaging configuration merge that isn't present after other similar merge blocks.

 if self.messaging.is_none() {
     self.messaging = config.messaging;
 }
-

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac35492 and 67bcc7f.

📒 Files selected for processing (1)

• crates/katana/cli/src/args.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: fmt

🔇 Additional comments (1)

crates/katana/cli/src/args.rs (1)

373-375: Ohayo! The messaging configuration merge logic looks good, sensei!

The implementation correctly prioritizes CLI arguments over config file values, maintaining consistency with other configuration merging patterns in the codebase.

[glihm]

Good catch thank you sensei. 🙏🏻

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.79%. Comparing base (ac35492) to head (a9335cc).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2941   +/-   ##
=======================================
  Coverage   55.79%   55.79%           
=======================================
  Files         444      444           
  Lines       57432    57435    +3     
=======================================
+ Hits        32042    32047    +5     
+ Misses      25390    25388    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.