refactor(torii): max conns to tasks & dont use sqlite acquire #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughOhayo, sensei! The pull request introduces modifications to database connection handling in the Torii runner and SQLite components. The changes focus on dynamically configuring the maximum number of database connections in the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
glihm
reviewed
Jan 15, 2025
| let cursors = sqlx::query_as::<_, (String, String)>( | ||
| "SELECT contract_address, last_pending_block_contract_tx FROM contracts WHERE \ | ||
| last_pending_block_contract_tx IS NOT NULL", | ||
| ) | ||
| .fetch_all(&mut *conn) | ||
| .fetch_all(&self.pool) | ||
| .await?; | ||
|
|
||
| let (head, last_pending_block_tx) = sqlx::query_as::<_, (Option<i64>, Option<String>)>( | ||
| "SELECT head, last_pending_block_tx FROM contracts WHERE 1=1", |
There was a problem hiding this comment.
Curiosity, why this 1=1 here?
There was a problem hiding this comment.
Acquire means you need to handle closing the connection yourself etc.. passing the pool directly will manage acquiring and cleaning it
There was a problem hiding this comment.
Curiosity, why this
1=1here?
idk
glihm
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Performance Improvements
Code Cleanup