Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to cairo 2.9.2 #2879

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
+1,732 −1,823
Open

feat: bump to cairo 2.9.2 #2879

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
d5038b6
wip: deps versionning
glihm Dec 6, 2024
83bf801
fix: add missing scarb field
glihm Dec 6, 2024
1fb3e30
chore: bump scarb
glihm Dec 6, 2024
4a3ade9
fix blockifier changes
kariy Dec 6, 2024
4ce7374
fix: update scarb related code for testing
glihm Dec 6, 2024
b60db4c
fix blockifier resource bounds mapping
kariy Dec 10, 2024
60d43dd
Merge branch 'main' into feat/cairo-291
kariy Dec 10, 2024
3126333
bump scarb version
kariy Dec 10, 2024
e380dda
cairo fmt
kariy Dec 10, 2024
5e77d22
tests: regenerate test databases
glihm Dec 10, 2024
e71beff
fix: bump cainome to fix event parsing
glihm Dec 10, 2024
914af81
fix: clippy
glihm Dec 10, 2024
fdd0956
fix contract call
kariy Dec 11, 2024
1deee22
add test for calling non legacy contract
kariy Dec 11, 2024
318571a
wip: fixing cairo compilation
glihm Dec 11, 2024
0f5b8c0
merge main
glihm Jan 8, 2025
4c3c27b
chore: bump to cairo 2.9.2
glihm Jan 8, 2025
c04cdc6
chore: update scarb
glihm Jan 8, 2025
443f034
fix: fmt and scarb update
glihm Jan 8, 2025
9f0d3c4
tests: regenerates test dbs
glihm Jan 8, 2025
60f97aa
fix: migrate to new scarb test functions
glihm Jan 15, 2025
68680d6
tests: regenerate test db
glihm Jan 15, 2025
2fb4521
merge main
glihm Jan 15, 2025
ce9a8e9
tests: regenerate test db
glihm Jan 15, 2025
7415519
ci: add scarb for test commands since it depends on scarb metadata
glihm Jan 15, 2025
703a066
fix(core-cairo-test): build external world class and adjust panick me…
glihm Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
- uses: actions/checkout@v3
- uses: software-mansion/setup-scarb@v1
with:
scarb-version: "2.8.4"
scarb-version: "2.9.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Heads up sensei! Version mismatch detected.

The Scarb version (2.9.1) in the CI workflow is behind the Cairo version (2.9.2) used in dependencies. Consider updating to 2.9.2 for consistency.

Apply this diff to align versions:

-          scarb-version: "2.9.1"
+          scarb-version: "2.9.2"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
scarb-version: "2.9.1"
scarb-version: "2.9.2"

- run: |
scarb --manifest-path examples/spawn-and-move/Scarb.toml fmt --check
scarb --manifest-path examples/simple/Scarb.toml fmt --check
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
scarb 2.8.4
scarb 2.9.2
starknet-foundry 0.30.0
Loading