Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change model query field to camel case #1410

Merged

Conversation

JunichiSugiura
Copy link
Contributor

@JunichiSugiura JunichiSugiura commented Jan 9, 2024

World explorer currently expects lower camel case model fields

Screenshot 2024-01-09 at 13 00 26

@JunichiSugiura JunichiSugiura force-pushed the fix(torii)/model-query-casing branch 2 times, most recently from 448dae3 to 1fc2b83 Compare January 9, 2024 20:32
@JunichiSugiura JunichiSugiura force-pushed the fix(torii)/model-query-casing branch from 1fc2b83 to e264d47 Compare January 9, 2024 21:08
@JunichiSugiura JunichiSugiura marked this pull request as ready for review January 9, 2024 21:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36e5853) 67.13% compared to head (e264d47) 67.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1410   +/-   ##
=======================================
  Coverage   67.13%   67.13%           
=======================================
  Files         231      231           
  Lines       20858    20858           
=======================================
  Hits        14003    14003           
  Misses       6855     6855           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarrencev tarrencev merged commit 042d46b into dojoengine:main Jan 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants