Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sozo): wait for tx to be accepted #1341

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat(sozo): wait for tx to be accepted #1341

merged 1 commit into from
Dec 28, 2023

Conversation

kariy
Copy link
Member

@kariy kariy commented Dec 28, 2023

This PR adds --wait cli flags for sozo commands that involve sending a tx (auth, execute, and register).

The flag is used to wait on the tx that is sent from the command. Waiting the transaction until it is executed/rejected by the sequencer.

Running the commands with --wait enable would return the tx receipt (in JSON) as the command output as opposed to just the tx hash (if --wait is omitted)

@kariy kariy linked an issue Dec 28, 2023 that may be closed by this pull request
@kariy kariy requested review from notV4l and glihm December 28, 2023 13:54
@codecov-commenter
Copy link

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (3fa7549) 65.08% compared to head (a452cae) 65.30%.
Report is 1 commits behind head on main.

Files Patch % Lines
crates/sozo/src/ops/execute.rs 0.00% 9 Missing ⚠️
crates/sozo/src/ops/auth.rs 0.00% 8 Missing ⚠️
crates/sozo/src/ops/register.rs 0.00% 8 Missing ⚠️
crates/sozo/src/commands/options/account.rs 0.00% 1 Missing ⚠️
crates/sozo/src/commands/options/transaction.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
+ Coverage   65.08%   65.30%   +0.21%     
==========================================
  Files         227      228       +1     
  Lines       19525    19628     +103     
==========================================
+ Hits        12708    12818     +110     
+ Misses       6817     6810       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarrencev tarrencev merged commit bd1fe3a into main Dec 28, 2023
9 checks passed
@tarrencev tarrencev deleted the 1192-wait-tx branch December 28, 2023 18:29
Larkooo pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SOZO] Add ability to wait for tx to finish executing
3 participants