Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(katana-provider): add tests for contract classes + fix provider state impl #1333

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

kariy
Copy link
Member

@kariy kariy commented Dec 27, 2023

Main purpose of this PR is to add tests for testing reading contract classes from both latest and historical state providers.

This PR also updates/fixes some bugs found in the providers' state impls thanks to the newly added tests.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ce4f395) 64.27% compared to head (960a847) 64.63%.

Files Patch % Lines
...ana/storage/provider/src/providers/fork/backend.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
+ Coverage   64.27%   64.63%   +0.35%     
==========================================
  Files         229      229              
  Lines       19713    19722       +9     
==========================================
+ Hits        12671    12747      +76     
+ Misses       7042     6975      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit 1a6d1ce into dojoengine:main Dec 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants